Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manifests): Add service account for repo server #9301

Merged
merged 1 commit into from
May 11, 2022
Merged

feat(manifests): Add service account for repo server #9301

merged 1 commit into from
May 11, 2022

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented May 4, 2022 •
edited
Loading

closes #9304

My K8s cluster applied the PodSecurityPolicies globally, so I need to add Roles and RoleBindings for my deployments.
For Argo CD, all the other deployments have their special ServiceAccounts, but argo-repo-server not.
It defaults to default.

I think it's a bit strange for the end users, so I add the sa for the repo server.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented May 5, 2022 •
edited
Loading

Codecov Report

Merging #9301 (5265aef) into master (87cabed) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9301      +/-   ##
==========================================
- Coverage   46.06%   46.04%   -0.02%     
==========================================
  Files         217      217              
  Lines       25908    25908              
==========================================
- Hits        11934    11929       -5     
- Misses      12317    12321       +4     
- Partials     1657     1658       +1
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 75.29% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87cabed...5265aef. Read the comment docs.

@haoxins
Copy link
Contributor Author

haoxins commented May 5, 2022

Check changes to generated code

This check failed because the change is expected.

@crenshaw-dev
Copy link
Member

@haoxins this looks great! Can you run make manifests? The changes to the base manifests are expected, but the CI also expects those changes to propagate to the generated manifests.

@haoxins
Copy link
Contributor Author

haoxins commented May 6, 2022

@haoxins this looks great! Can you run make manifests? The changes to the base manifests are expected, but the CI also expects those changes to propagate to the generated manifests.

done

@haoxins
feat(manifests): Add service account for repo server
5265aef 
Signed-off-by: Hao Xin <haoxinst@gmail.com>
crenshaw-dev
crenshaw-dev approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rwong2888
Copy link
Contributor

Will this be in the next release?

@crenshaw-dev
Copy link
Member

@rwong2888 yep once it's merged I'll cherry-pick it to 2.4.

@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label May 9, 2022
@crenshaw-dev crenshaw-dev requested a review from alexmt May 10, 2022 13:35
@crenshaw-dev
Copy link
Member

Did a local spot test, everything appears to be working. Merging.

@crenshaw-dev crenshaw-dev merged commit 7e39284 into argoproj:master May 11, 2022
crenshaw-dev pushed a commit that referenced this pull request May 11, 2022
@crenshaw-dev
feat(manifests): Add service account for repo server (#9301)
f9a307b 
Signed-off-by: Hao Xin <haoxinst@gmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
Copy link
Member

PR to cherry-pick: #9355

@haoxins haoxins deleted the feat-add-sa-for-repo-server branch May 11, 2022 03:40
crenshaw-dev added a commit that referenced this pull request May 11, 2022
@crenshaw-dev
feat(manifests): Add service account for repo server (#9301) (#9355)
74bc173 
Signed-off-by: Hao Xin <haoxinst@gmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Co-authored-by: Hao Xin <haoxinst@qq.com>
@crenshaw-dev
Copy link
Member

Cherry-picked into 2.4.

@almadigabor almadigabor mentioned this pull request Nov 23, 2022
Merged
@shvgn shvgn mentioned this pull request Nov 29, 2022
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@alexmt alexmt Awaiting requested review from alexmt

Assignees
No one assigned
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add service account argocd-repo-server for repo server
3 participants
@haoxins @crenshaw-dev @rwong2888